Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize next #511

Merged
merged 15 commits into from
Oct 20, 2018
Merged

Finalize next #511

merged 15 commits into from
Oct 20, 2018

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Oct 20, 2018

Closes #510. I started this finalize-next branch thinking there was more work but we're already done :) So this PR targets master directly. The last two commits are new.

After this we can update the changelog and upgrade guide on master (#512).

ralphtheninja and others added 15 commits September 22, 2018 11:08
* Location was removed from abstract-leveldown

* handle location in LevelDOWN constructor
* pass a factory function to abstract tests
* use tempy and remove cleanup code

* Add type check for location in constructor
* Target abstract-leveldown#ffba12f

* Use single test function from abstract-leveldown

* Target abstract-leveldown#d7411bb

* Options is actually now passed as options from abstract-leveldown and not a function
With undefined behavior for nullish targets (range options and
seek targets). Previously, nullish range options were ignored and
seek(null) and seek(undefined) would throw an error. Now they
translate to String(null) and String(undefined).

This change makes it explicit that leveldown only supports buffers
and strings. Nullish targets do have a meaning in the ecosystem;
that meaning should be given at a higher level like encoding-down.

In other words, it isn't leveldown's concern anymore.
Update next to latest abstract-leveldown
Migrate seek tests to abstract-leveldown
run()
})
db = testCommon.factory()
db.open({ xcacheSize: 0, xmaxOpenFiles: 10 }, function () {
Copy link
Member

@ralphtheninja ralphtheninja Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these really real properties? I know it's irrelevant to this PR, just curious.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's find out. I'm opening an issue.

@vweevers vweevers merged commit d979b30 into master Oct 20, 2018
@vweevers vweevers deleted the finalize-next branch October 20, 2018 15:45
@rvagg rvagg mentioned this pull request Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants